dirac-institute / sorcha

An open-source community LSST Solar System Simulator
Other
18 stars 18 forks source link

Adding version checker, better error messages #991

Closed astronomerritt closed 4 months ago

astronomerritt commented 4 months ago

Fixes #983.

Fixes #981.

Review Checklist for Source Code Changes

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.79%. Comparing base (316b2b6) to head (6423254). Report is 76 commits behind head on main.

Files with missing lines Patch % Lines
src/sorcha/utilities/sorchaArguments.py 66.66% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #991 +/- ## ========================================== + Coverage 80.73% 80.79% +0.06% ========================================== Files 69 69 Lines 3094 3083 -11 ========================================== - Hits 2498 2491 -7 + Misses 596 592 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mschwamb commented 4 months ago

It would be good for @mjuric to confirm the version stuff is okay. I think it is but a quickly double check would be helpful.