dirac-institute / sorcha

An open-source community LSST Solar System Simulator
Other
18 stars 18 forks source link

Adding linking config variables #992

Closed astronomerritt closed 3 months ago

astronomerritt commented 4 months ago

Fixes #953.

Fixes #954.

Fixes #975.

NOTE: I used Chile Standard Time for Chilean noon, hence 4pm UTC. Mario was using Chile Summer Time, which is why he has 2pm Chile = 5pm UTC. I don't know which one is correct here so I defaulted to Chile Standard Time, will change it back if needed.

Review Checklist for Source Code Changes

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.78%. Comparing base (9aae130) to head (cd20b7f). Report is 72 commits behind head on main.

Files with missing lines Patch % Lines
src/sorcha/modules/PPConfigParser.py 45.45% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #992 +/- ## ========================================== - Coverage 80.89% 80.78% -0.12% ========================================== Files 69 69 Lines 3094 3107 +13 ========================================== + Hits 2503 2510 +7 - Misses 591 597 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mschwamb commented 3 months ago

@astronomerritt can you resolve conflicts?

astronomerritt commented 3 months ago

Fixed!