Closed astronomerritt closed 3 months ago
Attention: Patch coverage is 64.70588%
with 6 lines
in your changes missing coverage. Please review.
Project coverage is 80.78%. Comparing base (
9aae130
) to head (cd20b7f
). Report is 72 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
src/sorcha/modules/PPConfigParser.py | 45.45% | 6 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@astronomerritt can you resolve conflicts?
Fixed!
Fixes #953.
drop_unlinked=True
.drop_unlinked=False
then the tally file will contain the linking information. Otherwise it will not.PPLinkingFilter()
andPPStats()
.Fixes #954.
drop_unlinked=False
,SSP_linking_on=True
andoutput_format=basic
, the object_linked column now appears in the default basic output.Fixes #975.
NOTE: I used Chile Standard Time for Chilean noon, hence 4pm UTC. Mario was using Chile Summer Time, which is why he has 2pm Chile = 5pm UTC. I don't know which one is correct here so I defaulted to Chile Standard Time, will change it back if needed.
Review Checklist for Source Code Changes