search

diracdeltas / signal-muon

Signal Desktop using https://github.com/brave/muon instead of Chrome. Not affiliated with WhisperSystems.
Mozilla Public License 2.0
122 stars 12 forks source link

Add data store and store window bounds #26

Closed mammuth closed 7 years ago

mammuth commented 7 years ago

I added a generic store handler, which still stores production and dev settings in different files. It also can handle defaults.

Right now it's only used for storing the window bounds. Bounds are updated when the window is closed.

Are you fine with handling userData this way, @diracdeltas ? There are no linting errors.

Fixes diracdeltas/signal-muon/issues/24

diracdeltas commented 7 years ago

thanks for this! this seems like a reasonable approach, assuming that https://github.com/diracdeltas/signal-desktop isn't saving the window sizes. (If so, I would prefer to get them from the signal-desktop extension in order to avoid having an app data store at all.)

mammuth commented 7 years ago

Thanks for the fast review. I changed the PR based on your comments.

diracdeltas commented 7 years ago

please git rebase -i to squash commits into one commit. thanks!

mammuth commented 7 years ago

Done. You're no big fan of using GitHub's shiny new button for Squashing and Merging directly from PR's?😉

diracdeltas commented 7 years ago

@mammuth actually i forgot it existed. thanks for the reminder!

diracdeltas commented 7 years ago

^ ping on requested changes

mammuth commented 7 years ago

Wups, didn't notice that you requested new changes 😊 sorry for the delay.