search

diracdeltas / signal-muon

Signal Desktop using https://github.com/brave/muon instead of Chrome. Not affiliated with WhisperSystems.
Mozilla Public License 2.0
122 stars 12 forks source link

getting ncp with npm install #28

Closed asafonov closed 7 years ago

asafonov commented 7 years ago

Setting ncp as a project dependency and use it in a build script. It's not a bad idea, isn't it?

asafonov commented 7 years ago

@diracdeltas I completely agree with you. Updated

diracdeltas commented 7 years ago

On second thought, it doesn't seem worth the effort to require ncp as a devDependency just for a single command where cp -r would work fine. Maybe just change it to cp?

asafonov commented 7 years ago

@diracdeltas Yes, the less dependencies the better. I changed build script, but I can't test on Windows

diracdeltas commented 7 years ago

thanks!