search

diracdeltas / signal-muon

Signal Desktop using https://github.com/brave/muon instead of Chrome. Not affiliated with WhisperSystems.
Mozilla Public License 2.0
122 stars 12 forks source link

Build on windows fails #43

Closed rgnuru closed 7 years ago

rgnuru commented 7 years ago

Building the package only works when commenting out some options in tools\buildPackage.js out:

cmds = cmds.concat([ 'node ./node_modules/electron-packager/cli.js . Signal' + ' --overwrite' + ' --platform=' + process.platform + ' --arch=' + arch + ' --version=' + electronVersion + // ' --icon=' + appIcon + ' --asar=false' // ' --app-version=' + signalVersion + // ' --build-version=' + electronVersion ])

also the command "mkdir" doesn't know the flag "-p" on windows: // cmds.push('mkdir -p ' + extensionsPath)

diracdeltas commented 7 years ago

adding the 'help wanted' label because i don't run Windows. it should be an easy fix (change the cmds conditionally depending on isWindows)

epsilontheta commented 7 years ago

That is due to a bug in brave/electron-packager (not renaming brave.exe leads to a subsequent fault https://github.com/brave/electron-packager/commit/50bd4db906f9b6ed0a11617891c5e81517e60695#diff-382da7e2b6e191171138bbcfc8c3a94c)

diracdeltas commented 7 years ago

closed by #53

sergeevabc commented 7 years ago

There is no Windows binary planned, right? :(