search

diracdeltas / signal-muon

Signal Desktop using https://github.com/brave/muon instead of Chrome. Not affiliated with WhisperSystems.
Mozilla Public License 2.0
122 stars 12 forks source link

Clarity about chrome #46

Open 3n-mb opened 7 years ago

3n-mb commented 7 years ago

It sounds like brave is using chromium. Electron is using chromium. Am I missing some difference between the two uses? Licensing?

3n-mb commented 7 years ago

From main page of this repo:

Signal Desktop built on top of Muon so you can run it without Google Chrome.

What's the deal?

leppert commented 7 years ago

@3n-mb I'm not sure I follow the question. Are you asking why the README says "you can run it without Google Chrome" when, in fact, Chromium underpins the project?

diracdeltas commented 7 years ago

Am I missing some difference between the two uses? Licensing?

see https://github.com/brave/muon/blob/master/README.md.

in addition, muon incorporates more chromium code, including the extensions system.

muon is also staying much closer to the chromium release schedule, which allows us to ship security updates faster.

3n-mb commented 7 years ago

@leppert yes, since electron also claims to be based on chromium.

3n-mb commented 7 years ago

Honestly, haven't heard about muon before yesterday.

Nonetheless, I added comments on issue #45 . Is it a case of incorrect docs in muon, that doesn't show strong default story, or is there an incorrect assumption about defaults here?

3n-mb commented 7 years ago

Has anyone tried to put signal code into electron? It looks that signal is a chrome app, more of an extension, unlike, say, current Cryptocat. Since muon says to be extension-friendlier, signal on muon sounds to be a logical development. Disclamer: I have no direct experience with extensions, so, these are vague guesses.