search

diracdeltas / spleeter4max

separate audio in ableton into stems using Spleeter
https://youtu.be/4pcJoI5CUOA
547 stars 51 forks source link

Feature/spleeter2update #54

Closed bytebraid closed 3 years ago

bytebraid commented 3 years ago

resolves #53

bytebraid commented 3 years ago

Pushed the change but shortened it the minor revision (2.1) as by definition there shouldn't be any breaking changes in a patch release...!

Cheers, Ciarán

On Wed, Feb 24, 2021 at 5:57 PM yan notifications@github.com wrote:

@diracdeltas commented on this pull request.

In README.md https://github.com/diracdeltas/spleeter4max/pull/54#discussion_r582177395 :

@@ -42,9 +42,7 @@ if you want to verify everything is installed on windows, download https://raw.g brew install python@3.7 brew link --force python@3.7 brew install ffmpeg -pip3 install spleeter==1.5.3 -pip3 install numba==0.48.0 -pip3 install numpy==1.18.5 +pip3 install spleeter

looks like 2.1.0 is the version we want

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/diracdeltas/spleeter4max/pull/54#discussion_r582177395, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQUK62UNBRBS4UTHIBZIGMLTAU4W3ANCNFSM4YEHIY7Q .

bytebraid commented 3 years ago

Despite what I said about patch releases in the previous email I'm not 100% on pip behaviour for patch versions... presumably they're defined by the package owner. Nevertheless running:

pip3 install spleeter

currently installs 2.1.2 on my system

however

pip3 install spleeter==2.1

favourably installs 2.1.0 and ignores the latest available patch

Not sure what's going on with that but hopefully it doesn't matter a huge deal for this change... let me know otherwise

Cheers, Ciarán

On Wed, Feb 24, 2021 at 5:57 PM yan notifications@github.com wrote:

@diracdeltas commented on this pull request.

In README.md:

@@ -42,9 +42,7 @@ if you want to verify everything is installed on windows, download https://raw.g brew install python@3.7 brew link --force python@3.7 brew install ffmpeg -pip3 install spleeter==1.5.3 -pip3 install numba==0.48.0 -pip3 install numpy==1.18.5 +pip3 install spleeter

looks like 2.1.0 is the version we want

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

diracdeltas commented 3 years ago

@skircher could you please download the zip from https://github.com/diracdeltas/spleeter4max/releases/tag/1.5 and let me know if it works? thank you!