Closed nephros closed 3 years ago
One issue: I can not test the Notification itself, because I build using coderu's docker images and test on a "3.4.0.24 (Pallas-Yllästunturi) device.
My builds with SDK 4.0.1.45, the daemon exits with this:
/usr/bin/harbour-batterybuddy-daemon: undefined symbol: _ZN12Notification8setSoundERK7QString
as soon as it wants to send the notification.
If I build against SDK 3.4.0.24, the Notifications API doesn't have the setSound() method.
Official release builds work fine though, including sounds, on the 3.4 device.
One issue: I can not test the Notification itself, because I build using coderu's docker images and test on a "3.4.0.24 (Pallas-Yllästunturi) device.
That's fine, I'll test the notifications using my devices.
My builds with SDK 4.0.1.45, the daemon exits with this:
/usr/bin/harbour-batterybuddy-daemon: undefined symbol: _ZN12Notification8setSoundERK7QString
as soon as it wants to send the notification.
If I build against SDK 3.4.0.24, the Notifications API doesn't have the setSound() method.
Official release builds work fine though, including sounds, on the 3.4 device.
Drat! This could break older version support (again). I may have to create a sfos3
branch or something. I may as well make it sfos2
branch to hit two stones with one bird. Good catch tho, I did wonder how I didn't see that before... I have been planning to fix my SailfishOS 2 application installation anyway, so now's a good to time to get to that.
There were conflicts regarding translations, so please check my resolve was correct :)
This is as far as I can take it ;) Can go on top of PR #43
As one can probably tell, I don't speak C++ very well so there's probably room for impovement :)
Everything seems to work correctly though, according to the logs.