direc85 / harbour-batterybuddy

Battery level alert for Sailfish OS
GNU General Public License v3.0
7 stars 8 forks source link

Notification sound should be splitted for upper and lower level notification #9

Closed CosmicDuck closed 3 years ago

CosmicDuck commented 4 years ago

I want notified only 1 time for upper limit but very often for lower limit. Would be nice you can split them. You can use the smallest interval to switch off the notification and longest interval to notifiy only one time. (- sign for never, ∞ for one time)

CosmicDuck commented 4 years ago

This is a whish

direc85 commented 4 years ago

That's a nice suggestion, and makes perfect sense! It shouldn't be too difficult to implement, but it still takes some time to do it, as it requires many new configuration file entries and refined logic.

I use the application so that the alert limits are outside the charger limits, so I don't hear the alarm unless the battery is really empty, and never for the upper limit, because charging stops before that. It's good to receive other use cases - such as only using the alerts, or using the alerts inside the charging limits.

direc85 commented 4 years ago

Oops, I didn't actually implement the "once" behavior...

direc85 commented 3 years ago

Implemented in aea2ef3 and fine-tuned in 041adb3 and f582d55.

direc85 commented 3 years ago

Whoops! Should have been "Fixes issue 22" but this was fixed, too.