Closed Olf0 closed 2 years ago
Thanks for the report. I was actually planning to open this myself, this was already mentioned in issue #4
The issue is QChart.js, which doesn't offer a method to highlight a bar easily, so the options are patching QChart.js or reimplementing it. After seeing the performance boost my radar view rewrite had, I'm going to implement similar graph drawing method in QML.
Thanks for the prompt and positive reply.
Actually outlining the bars was a bad idea:
So I think the top of the bars is the right spot to position an "in use" indicator. Maybe a simple white "top line" is sufficient to achieve this easily.
I have implemented this by changing bar colour: All active bars are the rssi color (like now) . inactive bars are all the same scale draw color. I tried to use border color, width and label color, but they do nothing. Chart does appear to put fine lines in the grid color around the bars (visible when you make the bar color "transparent")
I have been wasting time after finding that when I delete your gpsinfo install, my version doesn't run because Chart is unknown. I have just found that pulling gpsinfo from GH does make the chart folder, but does not get any of the files inside it. However none of it is part of the project file, so I have no idea where Chart came from.
Do you need to add QChart to the project file?
This is now "implemented-enough" in an already released version, so this can be closed. I'm still going to rewrite the barchart page to do without the external chart element - much like what I did to the radar page - but it's outside this issue.
Closing as fixed :)
Please also indicate on the bar graph page, which satellites are currently in use, as it is already the case on the polar view page. Preferably with the same way of indicating a satellite's use: a white outline around the coloured area (which depicts the satellite's signal strength).
The usefulness of this became apparent when trying to look further into the observation made in this side note.