direc85 / harbour-gpsinfo

GNU General Public License v2.0
5 stars 10 forks source link

New Features 1 #22

Closed sbridger closed 2 years ago

sbridger commented 3 years ago

Preliminary pull request, to establish that I can push working changes all the way back to you. QML is new to me, still trying to get my head around binding loops and so on, and thus there may be very bad code

Features:

direc85 commented 3 years ago

Thanks! Sounds good! I'll have to look at this later this week, so you have still time to refine your work, if you want ;)

sbridger commented 3 years ago

OK, so now it's a lot closer. I have pushed the changes, before I update qdevelop.

Haven't worked out how to get "timing" into firstpage.qml without the longform "providers.timing.secsSincePosition"

I will work on it some more this week, and tidy these issues up If you could just check that you can get and use my branch OK

direc85 commented 3 years ago

I reviewed your code and made some changes to the code.

The bar chart border rendering doesn't work as-is, I have to update QChart.js too. I'll try to do it later today.

After that, I'll comment/resolve the threads and let's see what the next step is :)

direc85 commented 3 years ago

Right, at this point I'll test this on my device. The looks of the bar chart is very much a subjective thing - personally I would just go with the solid-colored vs. transparent-bgcolor and forget about the border and text color. But we'll see what looks good :)

direc85 commented 3 years ago

Here is the current dev builds, if someone else would like to test them, too :)

harbour-gpsinfo-0.13.4-1-dev.zip

sbridger commented 3 years ago

I didn't have the borders working, and I thought it looked fine without. I think I just left the code in on the off chance it could be tried later. Don't waste time on it would be my advice.

Sadly my XA2 cellular modem died, and I reflashed droid to make sure it really was dead. Then my laptop died, so I think I have lost my latest version, and I can't currently try anything until I reflash sfos onto it. Then not sure if gps has died with the cellular. If gpsino is stored on my sdcard, I might be able to recover something.

From memory my last version changed the satellite drawing to sequence it and use transparency so active sat numbers can always be read properly.

direc85 commented 2 years ago

I'll just pull this now and polish it in master before release!