search

direc85 / harbour-gpsinfo

GNU General Public License v2.0
5 stars 10 forks source link

Implemented barchart RSSI view #6

Closed martonmiklos closed 4 years ago

martonmiklos commented 4 years ago

Depends on this PR in your QChart library: https://github.com/direc85/qchart.js/pull/1

The current implementation sorts the satellites in the order of their appearance. I think it is just fine now, but we might implement sorting in the future (by sat ID, RSSI).

direc85 commented 4 years ago

Wow, that was fast! Thanks for figuring out QChart for this!

The chart looks nice and indeed I would like to implement the option to sort it by RSSI instead of the satellite ID - both are good to have. I think the nested forEach() loop could be eliminated, and I have some optimizations in mind already. If it's okay to you, I suggest I merge this and then optimize it?

martonmiklos commented 4 years ago

If it's okay to you, I suggest I merge this and then optimize it?

Deal, if you merge it to upstream others can get aware of this feature easier which might bring some new ideas in this area.

My basic motivation was having ability to compare different devices GPS reception quality easier, but I will work on the selectable ordering.