search

direct-code-execution / ns-3-dce

Run real programs in the discrete time simulator ns3
http://www.nsnam.org/projects/direct-code-execution/
75 stars 46 forks source link

Update ns-3 versions #95

Closed tomhenderson closed 5 years ago

tomhenderson commented 5 years ago

Please add ns-3.30 release versions (including upcoming ns-3.30.2).

teto commented 5 years ago

do we really need the minor versions '3.30.2', '3.30.1' versions ? do they appear in the library name ?

tomhenderson commented 5 years ago

do we really need the minor versions '3.30.2', '3.30.1' versions ? do they appear in the library name ?

Yes. However, IMO the code should be rewritten to check against a regular expression and not a list. Would you accept that kind of patch instead?

teto commented 5 years ago

I suspect the idea of the list was to make sure we pick a supported version. Ideally I think the current search mechanism should just be replaced with pkg-config (which code I intend to merge as soon as I get the time) so I think the current patch is fine. If that's ok with you I will merge it.