directorlive / oppia

Automatically exported from code.google.com/p/oppia
Apache License 2.0
0 stars 0 forks source link

Code review request #628

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Branch name:
gallery-and-navbar

Link to the relevant commit(s):
https://code.google.com/p/oppia/source/list?name=gallery-and-navbar (there are 
three commits there)

Purpose of code changes on this branch:
Add new images to gallery and make slight changes to the shadows in the navbar.

NOTE: I wasn't sure which explorations you had in mind for the different 
categories on the splash page (e.g. algorithms, math, logic, languages, etc.), 
so I entered random exploration numbers in Gallery.js. Please change these to 
whatever explorations you think would be best. Thanks!

When reviewing my code changes, please focus on:
Code, good images

After the review, I'll merge this branch into: develop

Original issue reported on code.google.com by amitdeut...@google.com on 25 Feb 2015 at 4:45

GoogleCodeExporter commented 9 years ago
Hi Amit -- just to say I haven't forgotten about this, but it will take me a 
little while to handle it since I'm realizing I need to make the splash images 
+ explorationIds into admin config parameters. So, don't merge it yet; I'll do 
further work on the branch.

Thanks!

Original comment by s...@seanlip.org on 26 Feb 2015 at 6:42

GoogleCodeExporter commented 9 years ago
SGTM, thanks!

Original comment by amitdeut...@google.com on 26 Feb 2015 at 6:54

GoogleCodeExporter commented 9 years ago
LGTM, merged. Will handle admin config stuff in a separate pass.

Original comment by s...@seanlip.org on 28 Feb 2015 at 2:36