Code review request - Githubissues

directorlive / oppia

Automatically exported from code.google.com/p/oppia

Apache License 2.0

0 stars 0 forks source link

Code review request #636

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Branch name: redesign-dashboard

Link to the relevant commit(s): 
https://code.google.com/p/oppia/source/detail?r=c463479ce1e990345e9d7db2794192ce
f85c3254&name=redesign-dashboard

Purpose of code changes on this branch: Redesigning the dashboard to show tiles 
similar to gallery.

When reviewing my code changes, please focus on:
Naming convention used in css.
Duplication of methods from gallery.js in dashboard.js
Element class names in tiles.html

After the review, I'll merge this branch into: develop

Original issue reported on code.google.com by sbhow...@google.com on 27 Feb 2015 at 8:23

GoogleCodeExporter commented 9 years ago

Some quick notes from our conversation:

- fix created_on issue
- clicking on the exploration tile should bring you to the creation interface
- if a blank objective exists (as is the case for private explorations), I 
suggest writing, in grey italics, "No objective specified."
- the status (private, public, etc.) should be displayed in the bottom right 
corner.
Instead of sending three lists to the frontend, we should only send one; 
something like explorations_list.

Thanks!

Original comment by s...@google.com on 27 Feb 2015 at 10:08

GoogleCodeExporter commented 9 years ago

New commits

Original comment by sbhow...@google.com on 2 Mar 2015 at 5:46

GoogleCodeExporter commented 9 years ago

Actually adding new commits:
https://code.google.com/p/oppia/source/detail?r=21b5cd537250b1958e960f938abd5327
1758548c&name=redesign-dashboard#
https://code.google.com/p/oppia/source/detail?r=1afd8e48e57dc97eb20798d2981083c1
4d25b7f7&name=redesign-dashboard#

Original comment by sbhow...@google.com on 2 Mar 2015 at 5:47

GoogleCodeExporter commented 9 years ago

Adding updated screenshot (excuse the random names and objectives please):

Original comment by sbhow...@google.com on 2 Mar 2015 at 5:53

Attachments:

[Screen Shot 2015-03-02 at 10.41.12 AM.png](https://storage.googleapis.com/google-code-attachments/oppia/issue-636/comment-4/Screen Shot 2015-03-02 at 10.41.12 AM.png)

GoogleCodeExporter commented 9 years ago

Hey Shantanu

1. Make the 'p' of private and public capital.
2. Color code Private: Red and Public: Green.
3. Reduce the font size and make it equal to the exploration subheading. 
(Category. Last updated) 

Thanks

Original comment by bhaumikd...@gmail.com on 2 Mar 2015 at 6:06

GoogleCodeExporter commented 9 years ago

- Agree with (1).
- For (2), Amit and I think it's better to make the color code for 'private' 
grey, not red, since red gives too much of a sense of 'error'. (This was in the 
mock.)
- For (3), in general the font size should follow the mock (or the tiles in the 
gallery), if it doesn't already.

A general comment: the right-hand side doesn't look like the mock (even 
ignoring the 'feedback' row). Could it be changed to do so?

Thanks!

Original comment by s...@seanlip.org on 2 Mar 2015 at 6:55

GoogleCodeExporter commented 9 years ago

New commit:
https://code.google.com/p/oppia/source/detail?r=a8f4c584d12c26f9668c12970e984a7b
7e27cd20

Original comment by sbhow...@google.com on 2 Mar 2015 at 8:47

Attachments:

[Screen Shot 2015-03-02 at 2.16.38 PM.png](https://storage.googleapis.com/google-code-attachments/oppia/issue-636/comment-7/Screen Shot 2015-03-02 at 2.16.38 PM.png)

GoogleCodeExporter commented 9 years ago

Merged and closed. Thanks, Shantanu!

Original comment by s...@seanlip.org on 2 Mar 2015 at 9:02

Changed state: Done