directorlive / oppia

Automatically exported from code.google.com/p/oppia
Apache License 2.0
0 stars 0 forks source link

Code review request #641

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Branch name:
ratings-2

Link to the relevant commit(s):

When reviewing my code changes, please focus on:
I have made the rating and rating time two separate keys in the gae model, so 
that the former is indexable. This has the downside of being a bit less tidy 
but hopefully that's ok.

The test for the recording of rating times is a bit hacky so suggestions are 
welcome there.

After the review, I'll merge this branch into: develop

P.S. I've been having some issues with git. If you look at changes to the 
ratings-2 branch on Google code then it shows there as being no commits between 
Feb 4th and Feb 28th. However running git log on the branch shows it as having 
all the commits from develop during that period. Any idea what's going on?

Original issue reported on code.google.com by jacobdav...@gmail.com on 1 Mar 2015 at 7:48

GoogleCodeExporter commented 9 years ago
Forgot the commit!
https://code.google.com/p/oppia/source/detail?r=1e40f2e7b3c7c630ff9455fa21cc0fe7
45bcf7d0&name=ratings-2

Original comment by jacobdav...@gmail.com on 1 Mar 2015 at 7:49

GoogleCodeExporter commented 9 years ago
I think the approach you took with the gae model is fine, it's what I would do.

I made a suggestion for the rating times test.

For git, I think this branch is fine and you don't need to do anything. 
Sometimes the googlecode display is a bit weird. If you click 'next' you'll see 
some commits from within the Feb 4-28 period, so I'm guessing it's just a bit 
confused about ordering (this can happen when there are many merges).

Original comment by s...@seanlip.org on 1 Mar 2015 at 9:49

GoogleCodeExporter commented 9 years ago

Original comment by jacobdav...@gmail.com on 1 Mar 2015 at 10:14