search

directorlive / oppia

Automatically exported from code.google.com/p/oppia
Apache License 2.0
0 stars 0 forks source link

Code review request #642

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Branch name:
GalleryEditButton

Link to the relevant commit(s):
https://code.google.com/p/oppia/source/detail?r=e1a4b4c24615de38542671cb28596863
b9fd959d&name=GalleryEditButton

Purpose of code changes on this branch:
Changed how the edit button looks on the gallery exploration tiles. Attaching a 
image for the same. 

When reviewing my code changes, please focus on:

After the review, I'll merge this branch into: develop

Original issue reported on code.google.com by bhaumikd...@gmail.com on 2 Mar 2015 at 1:25

Attachments:

GoogleCodeExporter commented 9 years ago 
Assigning to Amit for review.

BTW, Debanshu, if this goes through review we may need to make it as a commit 
on the release branch instead. So, please don't merge to develop yet, even 
after getting lgtm!

Original comment by s...@google.com on 2 Mar 2015 at 5:48

GoogleCodeExporter commented 9 years ago 
LGTM, much cleaner. Thanks!

Original comment by amitdeut...@google.com on 3 Mar 2015 at 5:10

GoogleCodeExporter commented 9 years ago 
Great! Thanks Debanshu.

I've handled the merge and deleted the remote branch, so please don't worry 
about doing that. (I merged into release-2.0.0 instead of develop so that the 
change would also go out in the next release.)

Original comment by s...@seanlip.org on 3 Mar 2015 at 5:16

GoogleCodeExporter commented 9 years ago 
Thanks a lot :)

Original comment by bhaumikd...@gmail.com on 3 Mar 2015 at 6:33