search

directorlive / oppia

Automatically exported from code.google.com/p/oppia
Apache License 2.0
0 stars 0 forks source link

Code review request #687

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Branch name:
embed-modal

Link to the relevant commit(s):
https://code.google.com/p/oppia/source/detail?r=570c4325fb5bea5c4da296e3a1703257
f58f8478&name=embed-modal

Purpose of code changes on this branch:
Add additional information to the embed modal

When reviewing my code changes, please focus on:
What do you think of the current implementation with the accordion?

After the review, I'll merge this branch into: develop

Original issue reported on code.google.com by amitdeut...@google.com on 7 Apr 2015 at 11:35

GoogleCodeExporter commented 9 years ago 
Adding Amy to this code review.

Amy, would you mind checking out the branch embed-modal and taking a look at 
the UI? You can see the changes by going to an exploration and selecting share 
> embed in the topnav.

Thanks!
Amit

Original comment by amitdeut...@google.com on 9 Apr 2015 at 6:22

GoogleCodeExporter commented 9 years ago 
LGTM.

Original comment by amylat...@google.com on 9 Apr 2015 at 7:09

GoogleCodeExporter commented 9 years ago

Original comment by s...@seanlip.org on 10 Apr 2015 at 2:00