Closed GoogleCodeExporter closed 9 years ago
Another thought, we might want to show how many ratings have been given when we
display the rating in the gallery (e.g. 5 stars (8))
Original comment by amitdeut...@google.com
on 8 Apr 2015 at 10:20
4. Yet another thought -- at the moment, ratings show up too early when you get
to the end; the "Learned something new?" bit displays before the 'end
exploration' card appears. This looks really weird and should be fixed before
the next release.
Jacob, would you be able to look into these issues?
Original comment by s...@seanlip.org
on 18 Apr 2015 at 3:31
Also, Amit, I chatted with Jacob, and it seems sensible to defer (3) to when we
properly figure out what we want the design of the ratings display on the tile
to look like (since there was also talk of showing individual in addition to
average ratings, and it's also not clear what the '8' means). Is that ok?
Original comment by s...@seanlip.org
on 18 Apr 2015 at 3:38
Absolutely, we can do a second pass at the design of the ratings on the gallery
tiles after the upcoming release (unless you want to have that finalized
beforehand).
Original comment by amitdeut...@google.com
on 20 Apr 2015 at 6:22
Nope, later is fine.
Jacob, what's your ETA for (1), (2), (4)? I might be able to take on some of
these if necessary.
Original comment by s...@google.com
on 20 Apr 2015 at 9:24
(2) & (4) can be done this week if necessary but I'm not sure about (1).
Original comment by jacobdav...@gmail.com
on 20 Apr 2015 at 9:26
OK, I'd be fine with punting (1) to the next release.
Original comment by s...@google.com
on 20 Apr 2015 at 9:32
For (2) the "Featured" status currently is on the left and the rating is just
before it. The order is: rating, featured, category, last updated. What order
do you want, and do you want any components to be pulled to the right?
You might also want to consider dropping the star that goes with featured
status, to avoid confusion with the rating stars.
Original comment by jacobdav...@gmail.com
on 21 Apr 2015 at 12:50
Good questions,
My proposed order is:
category, last updated, featured, rating. I don't think they need to be pulled
to the right.
I would agree, let's remove the star from the featured status.
Thanks!
Original comment by amitdeut...@google.com
on 21 Apr 2015 at 12:54
Thanks for the quick reply! I have implemented (2) & (4) on the ratings branch
here:
https://code.google.com/p/oppia/source/detail?r=c2d81d848517cb2961d1803f277ebd74
6ed7a46a&name=ratings
Please let me know what you think, and Sean please review.
Original comment by jacobdav...@gmail.com
on 21 Apr 2015 at 1:11
Hi Jacob, code looks reasonable (thanks!), but did you see Amit's #9? Seems
like the star is still there in the user dashboard, and I think Amit wanted
'featured' before 'rating'.
Also did you test this? Looks like if an exploration isn't featured and there
are no ratings yet, you get a weird-looking second row that ends with a dot.
Similarly if the exploration is featured and there are ratings, there's no dot
separating them.
Original comment by s...@seanlip.org
on 21 Apr 2015 at 4:51
The dot issue cannot be easily fixed since the gallery does not know whether or
not ratings are present, and so whether to display a dot or not. I went with
this approach as it looks ok to me and avoids the risk of double dots if
ratings are not present.
Original comment by jacobdav...@gmail.com
on 21 Apr 2015 at 4:17
I played with this a bit, and resolved all the issues in a new branch:
https://code.google.com/p/oppia/source/detail?r=562f26b94ba6dfd92b21b1c7ba2258cb76573619&name=ratings-addVisibilityService
PTAL -- if it's ok, we can merge it. Thanks!
Original comment by s...@google.com
on 21 Apr 2015 at 9:44
Got confirmation from Jacob that this is fine, so merging to develop and
deleting both ratings and ratings-addVisibilityService. Will file (1) and (3)
as separate issues; closing this one.
Thanks!
Original comment by s...@seanlip.org
on 21 Apr 2015 at 10:14
For the record: filed issue 716 and issue 709 as follow-ups.
Original comment by s...@google.com
on 21 Apr 2015 at 10:23
Original issue reported on code.google.com by
amitdeut...@google.com
on 8 Apr 2015 at 9:07