directorlive / oppia

Automatically exported from code.google.com/p/oppia
Apache License 2.0
0 stars 0 forks source link

Code review request #713

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Branch name: ui-fixes

Link to the relevant commit(s): 
https://code.google.com/p/oppia/source/detail?r=ff28c76f8a0c7208d7ebc2d22332f2d6
b70a13e3&name=ui-fixes

Purpose of code changes on this branch: Various UI fixes.
(1) Change 'rule' to 'answer group'
(2) Change 'continue' rule to say 'clicking on the continue button'
(3) Fix subtext on updates/preferences pages being too far to the left
(4) Disable the dropdown for interactions with one rule type

When reviewing my code changes, please focus on: I actually think that just 
changing the name 'rule' to 'answer group' is a huge improvement. The only 
thing I'm not sure about is: in (4), is disabling the dropdown the correct 
thing to do?

After the review, I'll merge this branch into: develop

Original issue reported on code.google.com by s...@seanlip.org on 20 Apr 2015 at 7:40

GoogleCodeExporter commented 9 years ago
Some high-level thoughts on this:

-I don't see anything here addressing points (2) and (4), have they been 
implemented yet?
-Changing 'rule' to 'answer group' feels a bit premature, because first they're 
not really answer groups yet, and second we might want to ask Amy to test the 
terminology-- I'm worried people will find it to be confusing.

Original comment by amitdeut...@google.com on 21 Apr 2015 at 12:33

GoogleCodeExporter commented 9 years ago
+Amy

Based on offline chat, I reworked the continue button stuff. Turns out (4) is 
tricky, so not going to do it for this release.

Any thoughts on the current state of the branch? I think it's just 'answer 
groups' versus 'rules' that's the issue now, is that right?

@Amy, would you mind giving us some feedback on whether 'answer groups' is more 
or less understandable than 'rules'? Thanks!

Original comment by s...@seanlip.org on 21 Apr 2015 at 8:10

GoogleCodeExporter commented 9 years ago
Sean, what's your definition of an 'answer group'? That might help clarify my 
confusion here.

Original comment by amitdeut...@google.com on 21 Apr 2015 at 3:16

GoogleCodeExporter commented 9 years ago
An answer group represents a collection of answers (as opposed to a single 
answer). Note that a collection of answers may be defined by a rule.

Amit -- I made the changes we discussed. Should I merge to develop? Please also 
confirm you're happy with (2). This branch does not address (4).

    https://code.google.com/p/oppia/source/detail?r=328b69128f48108c0e8d00073f23ded7384e2709&name=ui-fixes

Thanks!

Original comment by s...@google.com on 21 Apr 2015 at 9:13

GoogleCodeExporter commented 9 years ago
Sounds good, thanks for making these changes! I went ahead +1'd the commits, 
feel free to add this to develop.

Original comment by amitdeut...@google.com on 21 Apr 2015 at 9:23