directorlive / oppia

Automatically exported from code.google.com/p/oppia
Apache License 2.0
0 stars 0 forks source link

In the history tab, long commit messages break the 'table' metaphor. #717

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create a new exploration.
2. Make a change, and then save the change, entering a long commit message.
3. Go to the history tab.

What is the expected output? What do you see instead?

I expect to see two neat columns: the commit message in one, and the action 
buttons in the other. Instead, the commit message overflows into the right-hand 
column.

It would also probably be a good idea to change "Apr 20 2015, 23:57 UTC" to 
something shorter.

Notes and other information:
- Assigning to Yuan as starter project.
- The relevant code is in core/templates/dev/head/editor/ExplorationHistory.js 
and exploration_history.html.
- For the datetime issue, we already have a method 
oppiaDatetimeFormatter.getLocaleAbbreviatedDatetimeString() which might be 
useful.

If you have any questions, please don't hesitate to ask. Thanks!

Original issue reported on code.google.com by s...@google.com on 22 Apr 2015 at 1:25

GoogleCodeExporter commented 9 years ago
Hi Sean,

Thanks for the notes, I've successfully updated the date time to a localized 
format.

For the overflowed messages, I would like to wrap it with a span or a div with 
the appropriate classes. Could you provide me some references pages so I could 
know which classes I should use? 

Thanks,
Yuan 

Original comment by yua...@google.com on 28 Apr 2015 at 3:16

GoogleCodeExporter commented 9 years ago
That's great, thanks Yuan!

I think it might be easiest to do something similar to

    core/templates/dev/head/editor/exploration_feedback.html

(which you can view by going to the feedback tab in the exploration editor). 
This uses a <table> and bootstrap classes like col-lg-1 etc. -- see 

    http://getbootstrap.com/examples/grid/

(Is this what you're looking for?)

Original comment by s...@seanlip.org on 28 Apr 2015 at 5:26

GoogleCodeExporter commented 9 years ago

Original comment by yua...@google.com on 2 May 2015 at 12:47