directorlive / oppia

Automatically exported from code.google.com/p/oppia
Apache License 2.0
0 stars 0 forks source link

Return to Gallery Box Empty in Embedded Explorations #804

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create an exploration with an end state that can be completed.
2. Embed the exploration on a page.
3. Go to the page and play through the embedded exploration to finish.

What is the expected output? What do you see instead?
There's a thin grey box where the "Return to Gallery" button usually is, but it 
has no contents. This box, if empty, should not show up (probably not at all in 
embedded mode).

Original issue reported on code.google.com by bhenn...@google.com on 3 Jun 2015 at 7:04

GoogleCodeExporter commented 9 years ago
This seems to me like it might be more of a content error, actually. Is there 
any reasonable case where it's reasonable for the end state to have no content? 
Perhaps that's something that should induce a warning message.

(Otherwise, say the previous state had a continue interaction. The learner 
presses continue and then -- nothing happens.)

Original comment by s...@google.com on 9 Jun 2015 at 12:58

GoogleCodeExporter commented 9 years ago
The bug is for the box underneath the content card itself. See pictures:

The first attachment is what it looks like (content or no content) if the 
exploration is completed directly in Oppia.

The second attachment is what the same exploration will look like if completed 
via an embedding.

Original comment by bhenn...@google.com on 9 Jun 2015 at 1:53

Attachments:

GoogleCodeExporter commented 9 years ago
Attempted a fix here, PTAL:

    https://code.google.com/p/oppia/source/list?name=release%2Fissue-804

Original comment by s...@seanlip.org on 10 Jun 2015 at 6:27

GoogleCodeExporter commented 9 years ago
That fixes the issue, thanks!

Original comment by bhenn...@google.com on 10 Jun 2015 at 5:59