Branch name: gadgets-develop-review
Link to the relevant commit(s):
https://code.google.com/p/oppia/source/detail?r=3dd1743f79d7875b54c3d0864d8e809f
fc0a2f30&name=gadgets-develop-review#
Purpose of code changes on this branch:
Consolidated commits from gadget-ui-editor branch for review. This commit
intends to deliver a "first functional milestone" for the Oppia gadget editor.
UX polish is not complete. Functional capabilities include
add/edit/delete/rename gadgets in any panel, while controlling visibility for
each state. Backend validation and tests are complete. Basic front-end
validation is in place, with two inline questions on remaining work.
When reviewing my code changes, please focus on:
- Front-end validation has two inline questions on how best to implement the
gadgets framework with all required files for each gadget remaining decoupled
in their gadget folder.
- Front-end test coverage: Karma tests are added for new changeListService
methods pertaining to gadgets, but there's a lot of new code on
explorationGadgetsService. Vishal requested a recommendation on how to approach.
- Overall approach & anything that can be improved.
After the review, I'll merge this branch into a new branch called:
develop-gadgets, a temporary branch reserved for gadgets-related work that has
been reviewed and approved where we can contribute incremental UX improvements
until the branch is ready for release.
Original issue reported on code.google.com by anu...@google.com on 19 Jun 2015 at 8:45
Original issue reported on code.google.com by
anu...@google.comon 19 Jun 2015 at 8:45