search

directorlive / oppia

Automatically exported from code.google.com/p/oppia
Apache License 2.0
0 stars 0 forks source link

Code review request for gadgets-develop-review #836

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Branch name: gadgets-develop-review

Link to the relevant commit(s): 
https://code.google.com/p/oppia/source/detail?r=df27b1a6328deac028ef88d1c41b9583
8380e9d4&name=gadgets-develop-review

Purpose of code changes on this branch:
- Refactored gadget width/height to use constants.
- Updated front-end validation to prevent saving of gadgets that don't fit 
their assigned panels.
- Updated backend tests accordingly.

When reviewing my code changes, please focus on:
- Anything that stands out.

After the review, I'll merge this branch into: N/A, still working towards full 
branch approval.

Original issue reported on code.google.com by anu...@google.com on 26 Jun 2015 at 11:40

GoogleCodeExporter commented 9 years ago

Original comment by s...@google.com on 26 Jun 2015 at 11:53