directus-labs / extensions

Experimental and community-maintained extensions for Directus
MIT License
38 stars 8 forks source link

Experimental m2a interface #15

Closed formfcw closed 4 months ago

formfcw commented 4 months ago

Everything should meet the requirements.

One small note: Since there is no clear indication which of the action buttons is a create button, I solved it by always taking the first one. So in the worst case, it will be labeled by "Add Existing" instead of "Create New", while providing the expected functionality.

binaryben commented 4 months ago

Since there is no clear indication which of the action buttons is a create button, I solved it by always taking the first one. So in the worst case, it will be labeled by "Add Existing" instead of "Create New", while providing the expected functionality.

Totally fine, thanks for letting us know about it

formfcw commented 4 months ago

The code for this is good and it functions well except for a small bug. The button matrix does not load on initial render of the page, but it loads after a refresh. Experimental.m2a.interface.screen.recording.mov

Once that's fixed, I can approve and merge. Thanks

@binaryben Fixed it (in a really hacky way)!

binaryben commented 4 months ago

in a really hacky way

const maxTries = 20;

Works for me! 😊