search

directus-labs / guest-authoring

A repo for our guest authors to work on content
12 stars 40 forks source link

Data Modeling and Permissions for a Leaning Management System #138

Closed marvelken closed 7 months ago

marvelken commented 7 months ago

Developing an Interactive Educational Platform with Directus

marvelken commented 7 months ago

Hi @phazonoverload , I have made the suggested edits, please take a quick look.

marvelken commented 7 months ago

Hi @phazonoverload , still waiting for your reply...

phazonoverload commented 7 months ago

You haven't addressed all feedback - please add descriptive alt text to each image, and remove the one that I've commented on. Thanks.

marvelken commented 7 months ago

Hi @phazonoverload , I just made changes to that sir.

phazonoverload commented 7 months ago

You have not added alt text to images. Please refer to this guide. https://www.smashingmagazine.com/2021/09/improving-accessibility-of-markdown/#2-write-meaningful-alternate-descriptions-for-your-images

I really want to see this post over the finish line, but as this is the third time I've given the same feedback, I'm afraid if you request a re-review without it being changed, I'll have to close this PR without acceptance to free up time to review other posts.

marvelken commented 7 months ago

Hi @phazonoverload, I am sorry for the stress! I thought you only referred to me adding an alt text for the one you highlighted above, so sorry for the stress. I will want to know if this is the last thing you'd want me to do in the draft, so you don't have to re-review as said.

phazonoverload commented 7 months ago

Thank you for writing this, and we are happy to consider it done in it's current state.

This repo is just for authoring/reviewing - the actual piece will be published via a Directus project, so we'll take it from here. I'll close this issue to keep the main branch clean, but this is a acceptance of your work.

Could you email me at devrel@directus.io and we'll share what we need to get you paid. Thanks!

Please also ensure you DELETE YOUR DIRECTUS CLOUD PROJECT IMMEDIATELY.