search

directus-labs / guest-authoring

A repo for our guest authors to work on content
12 stars 40 forks source link

Implementing Pagination and Infinite Scrolling in Next.js #226

Closed Tammibriggs closed 4 months ago

Tammibriggs commented 5 months ago

Hi @phazonoverload, I am done with the first draft for issue #194

phazonoverload commented 5 months ago

Thanks for your patience. I just wanted to let you know that I'll be reviewing this in the next couple of days.

Tammibriggs commented 5 months ago

Awesome!

Tammibriggs commented 5 months ago

Hi @phazonoverload, thanks for the compliment.

I have made the requested changes. I would like to point out that for the infinite scrolling due to the removal of the styling, the contents no longer span the entire height of the viewport, causing the next content to be automatically fetched without scrolling.

Tammibriggs commented 5 months ago

@phazonoverload I also made some modifications to the "When to choose between Pagination and Infinite scrolling" section in addition to the once requested.

phazonoverload commented 5 months ago

I would like to point out that for the infinite scrolling due to the removal of the styling, the contents no longer span the entire height of the viewport, causing the next content to be automatically fetched without scrolling.

If it's functional leave it in

Tammibriggs commented 5 months ago

@phazonoverload Done and corrected a couple of sentences.

phazonoverload commented 4 months ago

Thank you for writing this, and we are happy to consider it done in it's current state. My team will schedule it in to be published.

This repo is just for authoring/reviewing - the actual piece will be published via a Directus project, so we'll take it from here. I'll close this issue to keep the main branch clean, but this is a acceptance of your work.

Could you email me at devrel@directus.io and we'll share what we need to get you paid. Thanks!