search

directus / directus

The Modern Data Stack 🐰 — Directus is an instant REST+GraphQL API and intuitive no-code data collaboration app for any SQL database.
https://directus.io
Other
25.65k stars 3.57k forks source link

Favicon path not relative to public_url #20414

Open danielohling opened 6 months ago

danielohling commented 6 months ago

Describe the Bug

From what I can see in the network tab, directus tries to get the favicon from /root/ path instead of what is specified in public_url.

I run nginx and directus as a subfolder with proxy_pass on route /Api.

My main application is on the root path ./.

see print screens below:

Favicon /root path

Project Logo correct Path

Vue Router log error

I'm thinking it should fetch the favicon the same way as project_logo? and respect the path in public_url

To Reproduce

Add a new favicon i settings and logout och refresh the page.

Directus Version

v10.7.2

Hosting Strategy

Self-Hosted (Docker Image)

rijkvanzanten commented 5 months ago

I believe that's just the browser's default /favicon.ico load that kicks in before Directus' JS sets the favicon based on the settings 🤔

robinsonjohn commented 1 week ago

The JavaScript used by Directus to render the favicon does not render for me on any iOS devices (iPhone, iPad). When utilizing the Directus web app on an iOS device, the favicon is missing.

I have attempted to use both svg and png files, but neither have worked.

hanneskuettner commented 1 week ago

It seems like the Safari and Safari on iOS does not support SVG favicons^1 :( Tracking this in #22398 and seems unrelated to this issue.

robinsonjohn commented 1 week ago

It seems like the Safari and Safari on iOS does not support SVG favicons1 :( Tracking this in #22398 and seems unrelated to this issue.

Footnotes

1. https://caniuse.com/link-icon-svg [↩](#user-content-fnref-1-7426d98933b641e56a097e84c7f76bc1)

Thank you for this link. For the record, the favicon does not appear on iOS devices using either Safari or Firefox.

hanneskuettner commented 1 week ago

As Firefox on iOS is just a rethemed Safari, that totally tracks.