directus / gatsby-source-directus

Source plugin for pulling data into Gatsby from a Directus API.
10 stars 12 forks source link

fix: children of imageFile missing on build #4

Closed buttreygoodness closed 2 years ago

buttreygoodness commented 2 years ago

Fix for bug #1 . Children of imageFile in graphql queries were sometimes missing. Pre @chmielulu suggestion, refactored the image node creation to sourceNodes hook and reference those in the fileResolver.

KonstantinSolv commented 2 years ago

Hi guys, any timeline when this could be merged?

rijkvanzanten commented 2 years ago

Hi guys, any timeline when this could be merged?

Whenever it's ready. As of right now, there's an unresolved conversation which prevents this from being merged. Wanna take over the PR @KonstantinKaminski?

buttreygoodness commented 2 years ago

My apologies for the dealy.... Made changes to the document formatting. This change is untested but it works with my directus installation which contains a huge amount of images.

rijkvanzanten commented 2 years ago

@KonstantinKaminski Mind giving this PR a review to see if the solution is working for you? I'm no gatsby user myself 🙂