search

directus / v8-archive

Directus Database API — Wraps Custom SQL Databases with a REST/GraphQL API
https://docs.directus.io/api/reference.html
507 stars 203 forks source link

[Axios request timeout] increment the timeout value #2347

Open Castafiore opened 4 years ago

Castafiore commented 4 years ago

I want to upload a large file (about 2 GB), but every time it failed because of 10 minutes timeout limitation, so could you increment the timeout value of Axios instance in API.ts so that it can allow 30 minutes api call?

rijkvanzanten commented 4 years ago

@Castafiore feel free to open a PR for that 👍

Castafiore commented 4 years ago

@rijkvanzanten Submitted a new PR, please review it. And if it is confirmed, could that be applied immediately on directus repo?

rijkvanzanten commented 4 years ago

I can merge and deploy it as the SDK to npm right away, but I can't push out a whole Directus release for this change without further testing. For one, I'm not sure if the API will handle uploads of that size properly without https://github.com/directus/api/pull/1776 tested and merged.

Castafiore commented 4 years ago

@rijkvanzanten I understand that any change needs further testing, merge and deploy as SDK to npm is good for now, thanks! One more question: Once the change is deployed to npm, I want to clone the directus/app repo to local and build it from source, then I place the built dist folder to my local directus/public, then rename it to admin so it serves as admin app. Is this way possible ?

rijkvanzanten commented 4 years ago

Yup! That should work as expected :+1:

Castafiore commented 4 years ago

Cool, thanks. I will try it after the change is deployed to npm.

Castafiore commented 4 years ago

Hi @rijkvanzanten Could you merge and deploy the change as SDK to npm if you have time?

rijkvanzanten commented 4 years ago

Yeah, see my comment on the PR 👍

Castafiore commented 4 years ago

@rijkvanzanten Saw it, thanks.