bump version to node 20 and vscode 1.91.0

[0xBigBoss]

This PR bumps the esbuild target to node20 and sets the minimum vscode engine version to 1.91.0. This recent update to vscode bricked my direnv extension (it gets stuck on always loading in my project).

Building and installing with this patch seems to have resolved it. Sorry, I am not sure why the tests are failing. Hope this helps!

Version: 1.91.0
Commit: ea1445cc7016315d0f5728f8e8b12a45dc0a7286
Date: 2024-07-01T18:53:23.353Z
Electron: 29.4.0
ElectronBuildId: 9728852
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Darwin arm64 23.5.0

direnv --version
2.34.0

[mkhl]

Thanks for your contribution!Could you explain the upside of doing this?In the past I've updated the required vscode version when I had to to use a new feature.On 8. Jul 2024, at 16:11, Big Boss @.***> wrote:

You can view, comment on, or merge this pull request online at:   https://github.com/direnv/direnv-vscode/pull/801

Commit Summary

6246e2c bump version to node 20 and vscode 1.91.0

File Changes (2 files)

M
package-lock.json
(20)

M
package.json
(8)

Patch Links:

https://github.com/direnv/direnv-vscode/pull/801.patch https://github.com/direnv/direnv-vscode/pull/801.diff

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

[0xBigBoss]

Sorry, I don't have much context on how vscode versioning works with respect to extensions. I upgraded it since this vscode version upgrade electron and the nodejs version. https://code.visualstudio.com/updates/v1_90#_electron-29-update

Though, I guess I should have perhaps opened this up as an issue. The direnv vscode extension stuck on loading is what prompted me to investigate and ultimately try this patch.

Funny enough, no idea what's actually happening though since I reinstalled v0.17.0 today and everything works again. 🤷 Going to close.