search

dirkgroot / structurizr-dsl-intellij-plugin

IntelliJ plugin for the Structurizr DSL
MIT License
53 stars 3 forks source link

Tags for relationships are not supported #76

Open RedSlowpoke opened 1 year ago

RedSlowpoke commented 1 year ago

The tags for relationships broke the parsing with "CRLF expected, got 'model'" error to reproduce create any relationship like this

workspace {
    model {
        softwareSystem1 = softwareSystem "Software System 1"
        softwareSystem2 = softwareSystem "Software System 2"

        softwareSystem1 -> softwareSystem2 "Relationship" {
            tags test
        }
    }
}

works fine on the https://structurizr.com/dsl, but not in IDE

RedSlowpoke commented 1 year ago

Read some of your comments. If there is some rules that i should follow as “every value/tag/name should be quoted” or something similar let us know in the readme. I don’t think that it’s a problem, at least for me. Better it’s working while limiting the ways of stating the same provided by original DSL (which were possibly just an overlook).

dirkgroot commented 10 months ago

I've tested your example with the current version of the plugin, and it works correctly. Can you confirm that this works for you as well?

image

eddurov commented 9 months ago

Confirm that problem exists. It's about relationship, so example should be

workspace {
    model {
        softwareSystem1 = softwareSystem "Software System 1"
        softwareSystem2 = softwareSystem "Software System 2"

        relName = softwareSystem1 -> softwareSystem2 "Relationship" {
            tags test
        }
    }
}

without relName everything highlighted well. As said here https://docs.structurizr.com/dsl/identifiers#identifiers, it is possible to name relationships as well