search

dirkhh / adsb-feeder-image

Easy to use turn-key SD card image for a number of popular single board computers to run a complete ADS-B feeder
https://adsb.im/home
GNU General Public License v3.0
121 stars 12 forks source link

Roboto font still referenced #166

Closed afoeder closed 5 months ago

afoeder commented 5 months ago

In 32916f7 the remote call to Google has been removed. However, the Roboto font is still referenced as font-family in /src/modules/adsb-feeder/filesystem/root/opt/adsb/adsb-setup/static/css/mdb.min.css (search for --mdb-font-roboto).

I'm not familiar with the mdbootstrap.com ecosystem, if you know the cleanest way to remove it I'm open for suggestions :)

//edit: maybe an easier way would be to reintroduce the Roboto font, but locally (just like done with jquery in #150). I can do this, if you like. //edit 2: done via #167.

dirkhh commented 5 months ago

So - the neat thing about how these fonts work is that the browser will substitute the font with something "appropriate" for your platform on the fly. MDB themselves say that the Roboto font is optional and have tried to set things up to ensure a reasonable alternative is picked. (the same is not true for FontAwesome, unfortunately)

That said, I'm not opposed to to #167 - it just requires that we do the right thing from a license perspective.

afoeder commented 5 months ago

fully agree and I won't be mad if we didn't pick up #167 — in any case I'm able to familiarize with the project :)

My inner "Monk" just doesn't fee well when the CSS asks for Roboto and it's inherently not there. The CSS fallback is rather meant for network outages etc not not break the whole site suddenly. But license compliance is 100% necessary, I agree!

dirkhh commented 5 months ago

🙃 You are of course correct that this isn't ideal. I'm not sure which direction I prefer, TBH. I might be just very slightly biased towards keeping it simple and not adding more stuff - but then I should just look into removing Roboto, period.