search

dirkhh / adsb-feeder-image

Easy to use turn-key SD card image for a number of popular single board computers to run a complete ADS-B feeder
https://adsb.im/home
GNU General Public License v3.0
121 stars 12 forks source link

allow restart while aggregators are not yet chosen #200

Closed wiedehopf closed 4 months ago

wiedehopf commented 4 months ago
wiedehopf commented 4 months ago

I'm not convinced that this doesn't break the newly added feature of showing the stats of your newly added micro feeder(s) right away

It does a 'restarting' screen each time you add a micro feeder which is pretty quick. With the background thing, you could have things not getting applied, not getting started in some cases. And as mentioned elsewhere users always expect the state to match what they see in the interface.

Really i'd recommend you just give it a try when you find the time to see how non-disruptive this is. I've tested adding microfeeders extensively on the pi4 and that's pretty much the slowest hardware i'll expect for a stage2.

wiedehopf commented 4 months ago

not get merged with the message "error" being sent to the user. Duck that. I didn't change that error message (i think)? But i can add a commit that improves the error message.

Anyhow if you disagree about the consistency and background aspect that's fine, i'm not suck on my opinion on consistency and what users expect :) I can remove that part from the PR and keep it using the background logic.

dirkhh commented 4 months ago

Anyhow if you disagree about the consistency and background aspect that's fine, i'm not suck on my opinion on consistency and what users expect :) I can remove that part from the PR and keep it using the background logic.

no, this is fine