dirkjanfaber / victron-vrm-api

Interface with the Victron Energy VRM API
MIT License
11 stars 5 forks source link

Improvement Request #1

Closed suttridge closed 1 year ago

suttridge commented 1 year ago

Hi @dirkjanfaber, I have used this node for getting the solar PV forecast, and would suggest that you add options to set the start and end times to the request parameters, since leaving them off only gives the defaults timespan which is from the time one day ago, to the time of the request. Therefore, you cannot see the whole forecast for say, today, which requires a start time of midnight at the start of today, and an end time of midnight at the end of today (I see also that these timestamps are integer seconds, and not milliseconds - the API documentation sadly does not actually specify this - they just say a timestamp). BR, Steve

dirkjanfaber commented 1 year ago

Hello @suttridge. I already planned for adding selecting the timespan. Thanks for also looking into this. Anyway, selecting the needed span and interval is now possible in the latest update.