search

dirkjanfaber / victron-vrm-api

Interface with the Victron Energy VRM API
MIT License
9 stars 5 forks source link

Breaking change: treat the access token as a secret, do not export it #9

Closed codeworkx closed 8 months ago

codeworkx commented 8 months ago

Attention, this is a breaking change! The currently set token will be deleted and must be set again manually.

dirkjanfaber commented 8 months ago

I can set the version to 0.1.0, so that ought to give a hint about breaking changes. Probably most people will just hit update without realizing that might mean that the node stops working until they update their configuration.

But adding a configuration node makes sense.

codeworkx commented 8 months ago

guess this will fix our problem: https://github.com/dirkjanfaber/victron-vrm-api/commit/6bc17d6bca20121f1e296b87ad1a9c30ea7f042e#diff-f9884eb01b335ec683c0183837ca9460bca726b5ab36d2b75176adaa50b6f47bR7

dirkjanfaber commented 8 months ago

That looks better! Thanks! I'll publish a new release.