search

dirkjonker / sqlalchemy-turbodbc

SQLAlchemy dialect for Turbodbc
MIT License
23 stars 5 forks source link

Strings are no longer candidates for execution in sqlalchemy 2.x #14

Closed adamchen closed 1 year ago

adamchen commented 1 year ago

I noticed this morning that when we try and get the server version as part of opening a new connection it fails. This is because since 2.x, raw Python strings are no longer eligible for execution - they need to be wrapped in text() or similar.

I've verified this works in 2.x and also checked that it was backward-compatible with 1.4.x.

dirkjonker commented 1 year ago

@adamchen thanks

dirkjonker commented 1 year ago

@adamchen would you like to become maintainer or owner for this repository? I have not used Python/Turbodbc for years and am unlikely to use it in the future.

dirkjonker commented 1 year ago

Released as v1.2.0 https://pypi.org/project/sqlalchemy-turbodbc/1.2.0/

adamchen commented 1 year ago

Thanks @dirkjonker! I turned things down the first time as I wasn't really expecting to have to tweak stuff much, but I think at this point it may be sensible to be at least one of those things - possibly owner if you don't expect to work with it much in future?

dirkjonker commented 1 year ago

@adamchen I have sent you an invite, let me know your pypi.org username, then I will add you as a maintainer there as well!

adamchen commented 1 year ago

Thanks for sending that over - I've accepted! I'm also adamchen over at PyPi, will keep an eye out there as well :)