search

dirkjonker / sqlalchemy-turbodbc

SQLAlchemy dialect for Turbodbc
MIT License
23 stars 5 forks source link

Update parsing of read_buffer_size #19

Closed gsakkis closed 5 months ago

gsakkis commented 5 months ago

Update read_buffer_size parsing to Rows or Megabytes; currently neither works.

adamchen commented 5 months ago

Thanks for raising this, @gsakkis! I spent a bit of time wondering if there were a better way to specify MB vs rows, but given this is all coming from the sqla connection string I couldn't think of anything immediately obvious. I'll get this merged and built shortly.

gsakkis commented 5 months ago

@adamchen many thanks for the quick update! It would be great if you cut a new release so I can install it from pypi instead of my fork!

adamchen commented 5 months ago

Should be already done under 1.2.3 - let me know if I've messed up the upload though!

On Sat, 25 May 2024, 15:07 George Sakkis, @.***> wrote:

@adamchen https://github.com/adamchen many thanks for the quick update! It would be great if you cut a new release so I can install it from pypi instead of my fork!

— Reply to this email directly, view it on GitHub https://github.com/dirkjonker/sqlalchemy-turbodbc/pull/19#issuecomment-2131285263, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWQOBLEFBEIKJ6Q7BZDVL3ZECLJZAVCNFSM6AAAAABIILKIPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZRGI4DKMRWGM . You are receiving this because you were mentioned.Message ID: @.***>

gsakkis commented 5 months ago

Ah I was looking at the github releases, didn't realize it was already on pypi; thanks again!

adamchen commented 5 months ago

Ah, sorry - thanks for the nudge! I've updated that too :)