dirkschumacher / iUPB

A popular app for the University of Paderborn, Germany [project is dead]
http://www.i-upb.de
GNU General Public License v3.0
4 stars 2 forks source link

BWL A courses missing/not showing in calendar/list for week at Oct 14. #63

Closed Siedlerchr closed 10 years ago

Siedlerchr commented 10 years ago

Hi,

as you may know, next week (15. Oct) the new semester is starting). I came across a kind of bug which affects the BWL A courses for the week from Oct 14 to Oct 20 (Mo-Su). All other courses are displayed correcly and for the week after the Oct 14/20, all Bwl A courses show up, too. In the Paul tab and in Paul itself the events for BWL A are listed correctly:

http://www.i-upb.de/de/courses/350243511280757

The interesting thing, is that the courses for the week Oct 14 show up at my friends iUPB calendar correctly. That is how I found out about my problem :(

//EDIT: I Use Google/G+ Login

See screenshot below:

bwlamissing

Thx in advance for your help! Regards Siedlerchr

MichaelWhi commented 10 years ago

Hi Christoph, sorry for seeing this happen… Unfortunately, I cannot reproduce this, even with the same courses. Could you please try again from a different browser? Maybe this first one hour event was added later and the list of events is still cached in your browser… If that does not help, could you try removing the whole course and then adding it again? Hope that should solve it… And Sorry for the inconvenience.

Siedlerchr commented 10 years ago

Hi,

first of all, I always clear my browser cache (Firefox, latest version) and I even tested it after 24 hours again (next day) and the problem was still there. Maybe there is some caching on the i-upb/G+ account feature?

Well, I could fix it as you mentionend above. Removing and adding the courses again. Now shows up correctly.

So, I ask you, if you re-import all courses from paul, does the calendar gets updated? So maybe the fault was that the calendar didn't update correclty after re-import....

Kind regards, Siedlerchr

Siedlerchr commented 10 years ago

Hi, Hi guys,

I think I figured out why I had there some differences. I had created my first i-upb timetable in the first PAUL registration period and it seems that the course dates and some rooms have changed. The paul search is actual, it shows the correct dates and times, but in the calendar the "old/first" dates for the courses I have already added were wrong or still the dates from the first registration period.

Problem: Calendar View doesn't get updated after Paul change, only after removing and adding the course again

MichaelWhi commented 10 years ago

thanks for your investigation! everything you noticed is true, reproducible, and.... already fixed :) starting this weekend we exchange our old "pessimistic" updating method to a more "optimistic" one....

if you are interested: optimistic in a sense that it always assumes students want to have up to date events and now happily ignores events that were delete by the user... this was the reason before, we were not able to update courses if new events were added in paul; in those cases the number of events from paul differed from the number of events the user had. because we were pessimistic, we rather stopped the update. now we simply replace all non-custom events for a given course with fresh PAUL data. disadvantage is now, that deleted events will come back to the timetable after a PAUL update; but I hope users can live with that as the previously deleted events could have changed.

MichaelWhi commented 10 years ago

reference: https://github.com/dirkschumacher/iUPB/commit/530c8298d09eff8fa235c25634589a17591c1112#diff-4676c008b11a5480d73d4a6de01e45b9R97

Siedlerchr commented 10 years ago

Thanks for the Update! I think the current solution would be more pleased for the users. At least you should do an announcement on your website or in i-upb to inform the users of the new behaviour..

Regards Siedlerchr

MichaelWhi commented 10 years ago

we rolled out the new updater, which will be used for all forthcoming PAUL updates. I hope your timetable looks fine now, if not, please drop us a short note.

Thanks again for reporting this issue and helping us to track it down.