search

dirkschumacher / rcbc

COIN-OR branch and cut (CBC) bindings for R
https://dirkschumacher.github.io/rcbc/
Other
20 stars 5 forks source link

Status refactoring #25

Closed byapparov closed 6 years ago

byapparov commented 6 years ago

Hi @dirkschumacher, here is one more PR for you that moves status calculation to R code and makes it testable.

byapparov commented 6 years ago

timelimit status if model.isSecondsLimitReached() instead of unknown (implements #2)

codecov-io commented 6 years ago

Codecov Report

Merging #25 into master will increase coverage by 6.4%. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #25     +/-   ##
=======================================
+ Coverage    93.6%   100%   +6.4%     
=======================================
  Files           3      3             
  Lines         125    121      -4     
=======================================
+ Hits          117    121      +4     
+ Misses          8      0      -8
Impacted Files Coverage Δ
src/cpp_cbc_solve.cpp 100% <100%> (+13.11%) :arrow_up:
R/cbc_solve.R 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fc23e18...90588b8. Read the comment docs.