search

dirkschumacher / rcbc

COIN-OR branch and cut (CBC) bindings for R
https://dirkschumacher.github.io/rcbc/
Other
20 stars 5 forks source link

update cbc rwinlib version #46

Closed jeffreyhanson closed 3 years ago

jeffreyhanson commented 3 years ago

This PR updates the rcbc package to use the latest version of CBC available on rwinlib (i.e. 2.10.5) for Windows installation.

dirkschumacher commented 3 years ago

Great work, thanks to you and @jeroen! I wonder, if we can check the hash of the downloaded zip file for increased security using tools::md5sum (I believe there is no secure hash function in base R)? But that can also be a future PR of course :)

jeffreyhanson commented 3 years ago

Oooh - nice idea! That shouldn't be too tricky to implement, so I could give that a go now with tools::md5sum if you like (or is there another function you would prefer?)?

jeroen commented 3 years ago

Given that you're downloading over https, I don't think adding an md5 check really adds much. Also sometimes I move the tag to fix a bug in the library, so then the md5 check would fail.

dirkschumacher commented 3 years ago

Thanks @jeroen. Then let's don't it.

jeffreyhanson commented 3 years ago

Ok sounds good - thanks @jeroen and @dirkschumacher.

jeffreyhanson commented 3 years ago

Hmm, it seems like the CI tests are failing due to some internal GitHub Actions error.

The Windows build has the message:

GitHub Actions has encountered an internal error when running your job.

And the Ubuntu build has:

An unexpected error occurred when executing this workflow. Please submit a new support request using our Support website: https://support.github.com/contact Please include this unique ID in your request: 8E24:168C:892D5:EB033:6066440BShow

I'll double check that this isn't due to some bug in the PR locally.

jeffreyhanson commented 3 years ago

I've just double checked it installs successfully on Ubuntu and Windows. @dirkschumacher, could you please try restarting those GitHub Actions workflows?

jeffreyhanson commented 3 years ago

I've just tweaked some of the R code in tools/winlibs.R to trigger a rerun of the CI checks.

jeffreyhanson commented 3 years ago

@dirkschumacher, just letting you know that all the CI tests pass now (I guess this means the earlier build failures were due to internal GitHub reasons not related to the PR), so I think this PR is ready for you to review when you get a chance.

dirkschumacher commented 3 years ago

Also fixes #36

dirkschumacher commented 3 years ago

Thanks again!

jeffreyhanson commented 3 years ago

Awesome - thanks!