search

dirkvdb / ffmpegthumbnailer

Lightweight video thumbnailer that can be used by file managers to create thumbnails for video files
GNU General Public License v2.0
524 stars 72 forks source link

pkg-config file is broken when CMAKE_INSTALL_LIBDIR is absolute #215

Closed alexshpilkin closed 3 weeks ago

alexshpilkin commented 2 years ago

As per title: libffmpegthumbnailer.pc.in has

prefix=@CMAKE_INSTALL_PREFIX@
exec_prefix=${prefix}
libdir=${exec_prefix}/@CMAKE_INSTALL_LIBDIR@

and so can’t handle an absolute path in CMAKE_INSTALL_LIBDIR. This leads to a broken .pc file on NixOS in particular.

Similar to https://github.com/open-source-parsers/jsoncpp/pull/1199. See “Concatenating paths when building pkg-config files” for a discussion of the problem and a suggested fix (I don’t know CMake myself, sorry).