dirkvranckaert / my-episodes-watch-manager

Automatically exported from code.google.com/p/my-episodes-watch-manager
1 stars 2 forks source link

Change request: Small modifications to Coming tab #108

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
In ticket #66, you made some changes (per my initial request) to the "Coming 
tab"

Looks great, but I have a couple of additional suggestions:

1. Add number of shows in parenthesis for the day, i.e. December 10,2010 (4)
2. My preference would be to all list the day (m, T, W, etc.) and not just 
date. Not sure if others would want this.

Also, you mentioned, setting the preference in a future version. I'm guessing 
you mean whether you want to view the "coming tab" by show or by date. I think 
it's great to have the choice, in fact, rather than have it as a regular 
preference, my suggestion is to make it a toggle on the tab itself, maybe 
reached from the menu), so that it's easy to toggle between the two, without 
having to go all the way into preferences.

Again, great work on this app! I appreciate all the hard work you keep putting 
into it.

Original issue reported on code.google.com by scolapa...@gmail.com on 7 Dec 2010 at 10:48

GoogleCodeExporter commented 8 years ago
Related to issue 107

Original comment by dirkvran...@gmail.com on 8 Dec 2010 at 8:12

GoogleCodeExporter commented 8 years ago
I wrote some additional notes to issue 111 that somewhat related to these issues

Original comment by tnm.cont...@gmail.com on 8 Dec 2010 at 8:22

GoogleCodeExporter commented 8 years ago
I added the day in the list. Better?

Dirk, any ideas how to add number of episodes with the date listing?

Original comment by ivoniftrik on 12 Dec 2010 at 12:20

Attachments:

GoogleCodeExporter commented 8 years ago
Ok that's fine for me with the day of the week.

How did you implement it? If you have a look at the DateUtil class you'll see 
there are different methods available for formatting dates. Did you create an 
extra method "formatDateFull"?

Yeah I have some ideas for the number of episodes.
Currently to calculate which different dates to add to the list we have a 
List<Date> workinglist variable. The code would have to change to something 
like this (there can be errors in it, don't have a compiler here :p):

//Get all the airdates and the episode count
Map<Date, int> workingMap = new TreeMap<Date, int>();
for (Show show : shows) {
  for(Episode episode : show.getEpisodes()) {
    Date airDate = episode.getAirDate();
    if(!workingMap .containsKey(airDate)) {
      workingMap.put(airDate, 1);
    } else {
      int count = workingMap.get(airDate);
      workingMap.put(airDate, ++count);
    }
  }
}

//The map is a TreeMap (SortedMap) so sorting should not be done manually 
anymore unless we want the user to configure sorting order in the preferences

//iterate over map instead of the list
Set dateKeySet = workingMap.keySet();
for(Date date: dateKeySet) {
  //Rest of the adding code
}

Original comment by dirkvran...@gmail.com on 16 Dec 2010 at 11:11

GoogleCodeExporter commented 8 years ago
Yes I added a 'formatDateFull' method ;)
Thanks for the code, gonna try it.

Original comment by ivoniftrik on 16 Dec 2010 at 11:22

GoogleCodeExporter commented 8 years ago
Fixed, thnx for your code ;)

Original comment by ivoniftrik on 16 Dec 2010 at 6:35

Attachments:

GoogleCodeExporter commented 8 years ago
Ivo,

can you have a look at this again? When I was testing it didn't work for both 
the day of the week and the number of episodes... :s

Oh btw: Some of the names of the activities have changed so update fist... just 
so you know ;)

Original comment by dirkvran...@gmail.com on 22 Jan 2011 at 12:49

GoogleCodeExporter commented 8 years ago
added code from revision 401.

Original comment by ivoniftrik on 22 Jan 2011 at 2:31