search

dirkvranckaert / my-episodes-watch-manager

Automatically exported from code.google.com/p/my-episodes-watch-manager
1 stars 2 forks source link

200 unwatched limit removed. Parse views.php #130

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Hi 
I have written some code that will parse the views.php page that will allow as 
many unwatched eps as the user currently has.

The email on the project home page bounced back...

Would like to have my code added to the trunk so all users can benefit.

Attached is an example showing it is working..

I'd like to add a few more tweaks in but its close to done.

Thanks

Original issue reported on code.google.com by matthew....@gmail.com on 18 Nov 2011 at 7:18

Attachments:

GoogleCodeExporter commented 8 years ago 
Love it <3

Original comment by JimBi...@gmail.com on 20 Nov 2011 at 11:41

GoogleCodeExporter commented 8 years ago 
Please attach a patch-file to this issue and we'll have a look. But it looks 
great so we probably implement this :) I also updated the email adress on the 
project homepage! ;) Thanks for the effort.

Original comment by dirkvran...@gmail.com on 21 Nov 2011 at 8:25

GoogleCodeExporter commented 8 years ago 
Great! _0_

Original comment by ivoniftrik on 25 Nov 2011 at 11:09

GoogleCodeExporter commented 8 years ago 
I'm just working on being able to customise the views.php page by altering the 
control panel settings and reseting it again.
Thus allowing the app to show all unviewed tv without having to impact the 
browser experience.

Original comment by matthew....@gmail.com on 3 Dec 2011 at 11:10

GoogleCodeExporter commented 8 years ago 
Just doing the last few tests to make sure cp.php works correctly.

Hopefully put the .patch up in the next few days (a little late Christmas 
present).

Original comment by matthew....@gmail.com on 25 Dec 2011 at 9:49

GoogleCodeExporter commented 8 years ago 
I've attached the patch file which will enable the ability to have more than 
200 episodes listed in the watch tab. 

Usage:
In preferences "Enable 200+ episodes" and set the "Days backward" to the number 
of days wanted.

The settings on the website are stored then restored each time the app is run. 
This means the website on a computer will not be affected by the application.

Let me know if you've got any questions or find any bugs.

Thanks and Merry Christmas.

Original comment by matthew....@gmail.com on 26 Dec 2011 at 11:18

Attachments:

GoogleCodeExporter commented 8 years ago 
Did some testing, not really looked into code.

- (on first startup) crash if 'DAYS_BACK_CP' is null.
- DAYS_BACK_CP doesn't work? (set 1 or 500 days back, episodes to watch doesn't 
change here).
- It doesn't work on all accounts (StringIndexOutOfBoundsException), I can 
email you an account where it doesn't work.

Not you're fault, but it's too bad 'DAYS_BACK_CP' is needed, I guess most 
people use 'myshows.php' where this setting doesn't have any effect.

Sorry for creating extra work for you ;)

Original comment by ivoniftrik on 27 Dec 2011 at 12:47

GoogleCodeExporter commented 8 years ago 
No worries with the "extra work" i.e. I missed some testing...

Fixed the 'DAYS_BACK_CP' is null problem.
There appears to be a Android bug so it is set to True even when the code sets 
it to false. Due to this I have enabled the 200+ episodes by default. Not ideal 
but users can change it back if they wish. 
http://code.google.com/p/android/issues/detail?id=6641. I've cleared the 
settings and started the app and it doesn't crash for me.

I'm not sure why the DAYS_BACK_CP doesn't work. What does your 
http://myepisodes.com/views.php look like? should list all the shows you have 
to watch.
in the control panel what is the value for "Days backward should be shown in my 
list:"

Does the account where it doesn't work have a language other than English?

New patch file attached:

Original comment by matthew....@gmail.com on 27 Dec 2011 at 7:43

Attachments:

GoogleCodeExporter commented 8 years ago 
receiving StringIndexOutOfBoundsException when 'views.php' is empty (old series 
on that account).

When I set 'Days backward' on control panel to a larger number, I see more 
shows in MyEpisodes Manager. But changing the number in 
MyEpisodesManager-settings doesn't change number of episodes.

Original comment by ivoniftrik on 27 Dec 2011 at 9:18

GoogleCodeExporter commented 8 years ago 
Works when you change: "save" -> "Save" on line 421 (EpisodesService).

But now it messes up other settings like 'TimeZone' and 'Days forward' in my 
profile. Guess all these settings needs to be stored and restored.

Original comment by ivoniftrik on 27 Dec 2011 at 10:11

GoogleCodeExporter commented 8 years ago 
I can see what is happening with the StringIndexOutOfBoundsException. I'll work 
on handling when there are no episodes.

Something isn't working right with the patch file. 

The "Save" is already "Save" for me but its on line 401. The code block around 
it is:
[code]
String sw_currentseasononly;

        //default values should be same for all users.
        action = "Save";

        try{[/code]

line 421 for me is [code]"while ((line = reader.readLine()) != null) {"[/code]

Original comment by matthew....@gmail.com on 27 Dec 2011 at 10:28

GoogleCodeExporter commented 8 years ago 
The value you set in MyEpisodesManager-settings will not be visible when using 
your computer to check what the settings are. I'm already reading and storing 
values from cp.php. See the code around line 426 (EpisodesService) Starts with 
"String settingsHTML = HTMLcp.toString();" The next 100+ lines of code are then 
storing the values so they can be later restored.

Just looking at the .patch file and I can't see any of these lines of code in 
it.
Not sure what is going on.

I'm using TortoiseSVN to create the .patch file.

Original comment by matthew....@gmail.com on 27 Dec 2011 at 10:35

GoogleCodeExporter commented 8 years ago 
Ok, I'll stop with testing ;)
Maybe it's better that you can commit on this project.

Good luck with the last fixes! :)

Original comment by ivoniftrik on 27 Dec 2011 at 10:46

GoogleCodeExporter commented 8 years ago 
I figured out the problem.
Try this patch file, You should be able to test this now.

This patch should solve the no episodes IndexOutOfRangeException.

Let me know if you find anything else...

Known Issue:
I still need to work on stopping people from entering text in the days back 
range. I will work on that over the next day or so.

Original comment by matthew....@gmail.com on 28 Dec 2011 at 12:47

Attachments:

GoogleCodeExporter commented 8 years ago 
This patch works great!

You can solve your issue simply by adding:
'daysBackCP.getEditText().setInputType(InputType.TYPE_CLASS_NUMBER);'

Original comment by ivoniftrik on 28 Dec 2011 at 1:54

GoogleCodeExporter commented 8 years ago 
A yes now I think it's working perfect. Patch file attached.

As you suggested:
line 87 of PreferencesActivity should have the following line added
daysBackCP.getEditText().setInputType(InputType.TYPE_CLASS_NUMBER);

Look forward to the next official release with this added into it.

Original comment by matthew....@gmail.com on 29 Dec 2011 at 7:15

Attachments:

GoogleCodeExporter commented 8 years ago 
Committed, Did a few changes:
- Default of this setting is now false (because old series could not be shown, 
serie addics who have more then 200 episodes can turn this on)
- 'Days Backward setting' only enabled when 200+ is enabled.
- Changed all Log.e's to Log.d or deleted it. (you like the red color in debug? 
;))

We will release this soon, with a few other issues.

Thanks for your contribution. If you ever get bored, you're more than welcome 
to fix some issues or add other great features! :)

Original comment by ivoniftrik on 29 Dec 2011 at 10:34

GoogleCodeExporter commented 8 years ago

Original comment by ivoniftrik on 29 Dec 2011 at 10:50

GoogleCodeExporter commented 8 years ago 
Thanks.

The Log.e's made it easier to see in the debug output...

Thanks for the other two fixes. I was looking into - 'Days Backward setting' 
only enabled when 200+ is enabled but forgot about adding it...

Looking forward to 1.8.1

Original comment by matthew....@gmail.com on 29 Dec 2011 at 10:55