dirkwhoffmann / vAmiga

vAmiga is a user-friendly Amiga 500, 1000, 2000 emulator for macOS
https://dirkwhoffmann.github.io/vAmiga
Other
293 stars 24 forks source link

Changing screen configure with configure virtual machine #736

Closed bnice closed 1 year ago

bnice commented 1 year ago

Hi Dirk,

Just using vAmiga 2.1 . One thing that could be improved is not changing the screen colour when configure virtual machine is clicked. Why? Because when you are using the "Video" tab to adjust the screen, it would be helpful see how the controls are affecting the screen.

Regards,

Ben.

dirkwhoffmann commented 1 year ago

The darkening is done by the OS. It happens automatically when a sheet is displayed. But even without darkening it would not be optimal, because the sheet covers a large portion of the emulator texture. Maybe a preview image could be added to the video panel. I'll think about it...

bnice commented 1 year ago

Dam, sometimes the OS does the wrong the thing.

dirkwhoffmann commented 1 year ago

I've experimented with a couple of solutions:

Finally, I've decided to go for an approach which I've already used for the virtual keyboard. If the config panel is opened via the toolbar, it opens as a sheet (just as before). If the config panel is opened via the menu, the config panel is opened as a separate window. In this case, the emulator canvas is no longer darkened and fully visible.

bnice commented 1 year ago

Awesome :-)

dirkwhoffmann commented 1 year ago

Fixed in v2.2b1