search

dirkwhoffmann / virtualc64

VirtualC64 is a cycle-accurate C64 emulator for macOS
https://dirkwhoffmann.github.io/virtualc64
Other
356 stars 33 forks source link

Add JiffyDOS to list of known Roms #478

Closed dirkwhoffmann closed 5 years ago

dirkwhoffmann commented 5 years ago

Title says it all.

Alessandro1970 commented 5 years ago

This is good !

dirkwhoffmann commented 5 years ago
screenshot 2018-12-04 at 16 18 00

Hash values have been added. Please let me know if I should display different names for the Roms.

mortinus commented 5 years ago

They are ok

tsupplis commented 5 years ago

Hi Dirk, I get a different value for the 1541-II rom (bought through retro innovation) ./chksum JiffyDOS_1541-II_6.00.bin F7F4D931219DBB5D

dirkwhoffmann commented 5 years ago

As far as I know, 'cheksum' computes a CRC code. VirtualC64 computes a FNV-1a hash value, because it's super easy to calculate (OK, CRC is not rocket science either, teaching it every semester in my class).

Can you check which hash value is displayed inside VirtualC64? It is of course possible that there are multiple JiffyDOS versions around. I would then have to add new hash values.

tsupplis commented 5 years ago

I used your hash function to create the output above . my checksum is giving the same value as yours for all the other roms. But not the DOS 1541. I found on the web one rom that has the same hash as specified in your code but the official commercial rom has a different hash.

Attached the snipped I used to check the value. I also verified that this is the value displayed in the UI.

image

dirkwhoffmann commented 5 years ago

I've added it to the list of known VC1541 Roms. The following images are recognized by name at the moment: 

let knownVc1541Roms : [UInt64: String] = [
    0x0000000000000000:
    "This 16 KB Rom contains the firmware of Commodore's VC1541 floppy drive.",
    0x44BBA0EAC5898597:
    "1541-II firmware released in 1987",
    0xA1D36980A17C8756:
    "1541-II firmware appearing in drives with a modern Newtronics Motor",
    0x361A1EC48F04F5A4:
    "Firmware of the old-style 1541 in white case",
    0xB938E2DA07F4FE40:
    "Upgraded firmware for the 1541C drive",
    0x47CBA55F16FB3E09:
    "1541-II firmware with relocation patch",
    0x8B2A523E29BED889:
    "1541-II firmware (JiffyDOS patch)",
    0xF7F4D931219DBB5D:
    "1541-II firmware (JiffyDOS patch 6.00)"
]
tsupplis commented 5 years ago

Cool, thank's

image