dirkwhoffmann / virtualc64

VirtualC64 is a cycle-accurate C64 emulator for macOS
https://dirkwhoffmann.github.io/virtualc64
Other
342 stars 33 forks source link

Add MAME SID implementation as another sound backend #776

Closed dirkwhoffmann closed 5 months ago

dirkwhoffmann commented 6 months ago

Currently, VirtualC64 offers reSID and FastSID as audio backends, with the latter not at all being competitive in terms of quality.

As an experimental project, it should be tried to add MAME's SID implementation. The implementation is licensed under the BSD clause, except for two data tables taken from reSID. If the new backend proves to be suitable enough (without the data tables, which only cover some unusual scenarios where multiple waveforms are activated simultaneously), reSID could be removed. This is a requisite to change the license of VirtualC64 from GPL to BSD, which I want to do eventually.

https://github.com/mamedev/mame/tree/master/src/devices/sound

dirkwhoffmann commented 6 months ago

The MameSID branch contains an experimental version of VirtualC64 with the MAME SID backend included:

Bildschirmfoto 2024-01-20 um 12 40 08

The good:

The bad:

Assuming there is no configuration error, I don't think merging the code back to the main branch makes sense. It would just bloat the app without adding any substantial improvement.

Haroldo64 commented 5 months ago

Hi, there is a new RESID version in VICE 3.8:

Could Virtualc64 work better with this upgrade importing it into ?

Thanks