search

dirruk1 / gnome-breeze

Attempt to create a Breeze gtk-3 theme. GTK2 theme made by scionicspectre
https://github.com/scionicspectre/BreezyGTK
GNU Lesser General Public License v2.1
129 stars 16 forks source link

Gtk2-Breeze: Make the whole scrollbar area draggable #35

Closed nowrep closed 9 years ago

nowrep commented 9 years ago

This makes it possible to move the cursor to the edge of the screen and still be able to interact with scrollbars in case of maximized windows.

Second attempt, this time it should be correct.

Fixes #31

ghost commented 9 years ago

Thanks for taking the time to rework this patch. I'm afraid I didn't get here in time to let you know that, since these assets are generated from assets.svg, we'll need to make the change there before automatically rendering the assets to the files you've changed manually.

One reason is for convenience, the other being that we need this workflow intact for when we eventually merge the color scheme code, as it changes the rendered color dynamically. Still, I don't see any reason why I would need to change the gtkrc modifications you've made, so I'll make full use of that. Once I figure out the best way to add the invisible space to the .svg, we should have this fixed.

Apologies for not being able to use this as-is. I really do appreciate the work.

nowrep commented 9 years ago

Sure, no problem, I kind of expected it to not be accepted for those reasons ;) But at least you may use it the next time you'll work on assets.svg. Also other users can apply this manually.

To the changes in gtkrc:

GtkScrollbar::trough-border = 0 - this disable the non-draggable border "margin" around all elements in scrollbar GtkScrollbar::slider-width = 20 - now that we don't have the trough-border, this is needed to add some sane margin to scrollbar arrows (5 + 5 border which was before used from trough-border)

border = { 30, 30, 5, 5 } - this is actually only needed for horizontal scrollbar (no idea why, because it works fine with 25 25 borders for vertical scrollbar, and both images are exactly the same ...), so I just changed it in both vertical and horizontal

ghost commented 9 years ago

Cool, thanks for understanding and thanks again for the effort. I'll be creating a new branch soon specifically tailored for merging upstream so these changes are likely to land there. Hopefully people won't have to rely on manual changes for long. ;)