search

dirruk1 / gnome-breeze

Attempt to create a Breeze gtk-3 theme. GTK2 theme made by scionicspectre
https://github.com/scionicspectre/BreezyGTK
GNU Lesser General Public License v2.1
129 stars 16 forks source link

Scrollbar arrows are misaligined in GTK2 Breeze theme #42

Open shmerl opened 9 years ago

shmerl commented 9 years ago

Here is an example of top scroll bar arrow from Firefox 42 using Breeze dark GTK 2 theme (shown with KDE magnifier). Same thing really happens with the bottom arrow as well. Notice thin green lines which I put to highlight the misalignment which is slightly to the right:

misaligned_scrollbar

ghost commented 9 years ago

This is partly due to trying to match the upstream Qt Breeze assets which scale the arrows per scrollbar. Some scrollbars are thicker or narrower depending on the application, and the default has an even pixel count. Since the arrow comes to a point that is one pixel wide at the default size, this requires us to have an arrow that is an odd pixel count. Even if we made it an even pixel count, it would become similarly misaligned.

The solution would be to modify the arrow or the slider to be less like Qt's assets to align the center either on a pixel or the subpixel between the two middle pixels. Since most Qt apps scale the arrows instead, I suppose that would be the 'correct' adjustment to make.

This deserves more discussion with the other artists involved, I'll get back to you.