Theme doesn't honor color scheme

[sez11a]

Seems like the Breeze color scheme is hard-coded into the GTK theme. The oxygen-gtk(2)(3) theme honors the color scheme chosen. Can you make the Breeze theme honor the KDE color scheme? See screenshot comparison between Dolphin and VIM.

[xenithorb]

Try following what I wrote here: https://github.com/dirruk1/gnome-breeze/issues/8#issuecomment-226850549

I didn't need to specify the .colors file, after picking the right colors for your KDE environment, it uses that merged colors file to generate. Remember that the context of this is so that it can be run every time someone selects a new color scheme.

[shmerl]

There is no more build_theme.sh, and default produces same result actually. I just specified explicit color file to be sure.

Also, your method makes a symlink, but repo contains 3.20 in addition to 3.0. And running the script regenerates only 3.0 theme, so just symlinking can cause confusion. I just deploy it explicitly, and it places gtk-3.0 in the theme dir.

[xenithorb]

@shmerl well since this is git, i can tell you that f10b6f3b477efc6890453a4c5377dadf8472ac8e works as I described still. You can always check that out and go about your day unless you're just testing around

[shmerl]

Well, yes, I can revert to older revision. I was more interested in whether the latest code in the branch is broken for others too, or I'm doing something wrong.

[shmerl]

Yes, that's the revision which works for me (just tested it): https://github.com/dirruk1/gnome-breeze/commit/f10b6f3b477efc6890453a4c5377dadf8472ac8e

The next one: https://github.com/dirruk1/gnome-breeze/commit/432fae49622f25184142180d444dcd49eed22430 introduced a regression already.

[dirruk1]

@shmerl I've been on a holiday, I won't have much time this week. I will look into it next week. @xenithorb I know you probably mean well but suggesting someone should revert back to stable versions when he is reporting about problems is not a good thing. Reporting bugs is the most important thing about testing. Bug reports are realy important thing when it comes to fixing problems

[xenithorb]

I felt slightly responsible for announcing (on this ticket, in my excitement) that it was working at some point, thus I wanted to provide that commit because my local repo was still checked out to it (as I'm still using it). I didn't know if it was marked somewhere else as being a working commit hash, if it was tagged, etc.

[dirruk1]

Don't worry, I always appreciate everyone who is contributing. Just wanted to make sure @shmerl knows his bug reports are appreciated

[flying-sheep]

hi. what’s the state?

the official version of this repo (https://quickgit.kde.org/?p=breeze-gtk.git) doesn’t have the scripts, only the data.

so is this repo still the upstream? and does someone still plan to autobuild the color theme adapted version?

[xenithorb]

The script breeze-gtk-color on most recent kdeglobals fails with:

Traceback (most recent call last):
  File "./breeze-gtk-colors", line 725, in <module>
    border_color            = Color(kde_globals,'WindowBackgroundNormal','WindowForegroundNormal', 0.75)
  File "./breeze-gtk-colors", line 26, in __init__
    self.dis = self._color_effect(self._intensity_effect(self.rgb,'Disabled'),'Disabled')
  File "./breeze-gtk-colors", line 71, in _intensity_effect
    amount = float(self.colordict[state + 'IntensityAmount'])
ValueError: could not convert string to float:

and later

Traceback (most recent call last):
  File "./breeze-gtk-colors", line 725, in <module>
    border_color            = Color(kde_globals,'WindowBackgroundNormal','WindowForegroundNormal', 0.75)
  File "./breeze-gtk-colors", line 26, in __init__
    self.dis = self._color_effect(self._intensity_effect(self.rgb,'Disabled'),'Disabled')
  File "./breeze-gtk-colors", line 71, in _intensity_effect
    amount = float(self.colordict[state + 'IntensityAmount'])
ValueError: could not convert string to float:

and later

Traceback (most recent call last):
  File "./breeze-gtk-colors", line 725, in <module>
    border_color            = Color(kde_globals,'WindowBackgroundNormal','WindowForegroundNormal', 0.75)
  File "./breeze-gtk-colors", line 26, in __init__
    self.dis = self._color_effect(self._intensity_effect(self.rgb,'Disabled'),'Disabled')
  File "./breeze-gtk-colors", line 86, in _color_effect
    effect = int(self.colordict[state + 'ColorEffect'])
ValueError: invalid literal for int() with base 10: ''

This is due to the following in kdeglobals

[ColorEffects:Disabled]
Color=
ColorAmount=
ColorEffect=
ContrastAmount=
ContrastEffect=
IntensityAmount=
IntensityEffect=

If you set them all to 0 the script works again.